-
-
Notifications
You must be signed in to change notification settings - Fork 34.6k
Do not count netdata cleared and undefined alarms as warnings #37505
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ion from the netdata host
MartinHjelmare
approved these changes
Jul 5, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
For the future, please start on a fresh branch when starting a new fix or feature. There are now old commits in this branch. |
Yes, sorry. Will remember next time. |
MartinHjelmare
approved these changes
Jul 5, 2020
Ready to merge? |
Yes, good to go |
hahn-th
pushed a commit
to hahn-th/core
that referenced
this pull request
May 2, 2025
…t#37505) Bumps [ruby-lsp](https://github.com/Shopify/ruby-lsp) from 0.23.10 to 0.23.11. - [Release notes](https://github.com/Shopify/ruby-lsp/releases) - [Commits](Shopify/ruby-lsp@v0.23.10...v0.23.11) --- updated-dependencies: - dependency-name: ruby-lsp dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Fix a remaining problem for alarm handling introduced in #34339 which did not ignore cleared or undefined alarms when calculating the sensor state.
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.The integration reached or maintains the following Integration Quality Scale: