-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Document rebuilding addons with force #2718
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
📝 WalkthroughWalkthroughThe documentation for the Changes
Sequence Diagram(s)No sequence diagram generated as the changes are limited to documentation updates. 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
docs/api/supervisor/endpoints.md (1)
373-375
: Consider specifying the default & version-gateReaders may wonder what happens when
force
is omitted and from which Supervisor version the flag is supported. Adding something like “Defaults tofalse
; available since Supervisor ≥ 2024.06” would remove any ambiguity.-| force | boolean | True | Force rebuild the add-on, even if it has `image` set in its `config.yaml` | +| force | boolean | True | Force rebuild the add-on, even if it has `image` set in its `config.yaml` (default: `false`, Supervisor ≥ 2024.06) |
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge Base: Disabled due to data retention organization setting
📒 Files selected for processing (1)
docs/api/supervisor/endpoints.md
(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: Redirect rules - developers-home-assistant
- GitHub Check: Header rules - developers-home-assistant
- GitHub Check: Pages changed - developers-home-assistant
🔇 Additional comments (1)
docs/api/supervisor/endpoints.md (1)
370-376
: Payload table looks correct 👍Column order, casing (
boolean
), and “optional” flag match surrounding sections. No further action needed.
e541c3c
to
afd43c9
Compare
@agners maybe it's a good time to merge this PR now that a new version of Supervisor was released with the change. There's home-assistant-libs/python-supervisor-client#133 too. |
Proposed change
Documents the
force
option for theaddons/<addons>/rebuild
endpoint in the Supervisor API, which allows users to force a rebuild of an add-on even if it has an image set in itsconfig.yaml
.This is useful for testing changes to the add-on, avoiding the need for commenting out the image line in the config.yml file.
Type of change
Checklist
Additional information
/cc @agners
Summary by CodeRabbit
Summary by CodeRabbit
/addons/<addon>/rebuild
endpoint to include a description of the new optionalforce
parameter in the POST request payload.