-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Add information about onTag Github Action workflow #2729
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
📝 WalkthroughWalkthroughThe documentation for Android CI was updated to clarify the F-Droid link wording, add a new section describing the Changes
Sequence Diagram(s)sequenceDiagram
participant Developer
participant GitHub
participant Workflow (onTag.yml)
participant Pull Request
Developer->>GitHub: Pushes tag (CalVer format)
GitHub->>Workflow (onTag.yml): Triggers workflow
Workflow (onTag.yml)->>Pull Request: Creates PR to update changelog_master.xml
Developer->>Pull Request: Manually reviews and approves PR
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
docs/android/ci.md (2)
93-96
: Missing comma after introductory clause
Add a comma after “pushed” to avoid a run-on sentence and improve readability.-When a tag that matches the [CalVer] versioning format is pushed the `onTag.yml` workflow is triggered. +When a tag that matches the [CalVer] versioning format is pushed, the `onTag.yml` workflow is triggered.
101-107
: Align wording with other trigger descriptions
For consistency with “On push tomain
” and “On PR open or update”, consider rephrasing the trigger column from “On tag pushed” to “On tag push” or simply “On tag”.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge Base: Disabled due to data retention organization setting
📒 Files selected for processing (1)
docs/android/ci.md
(2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: Redirect rules - developers-home-assistant
- GitHub Check: Header rules - developers-home-assistant
- GitHub Check: Pages changed - developers-home-assistant
🔇 Additional comments (1)
docs/android/ci.md (1)
90-90
: Link text is now descriptive – good accessibility improvement
Replacing the vague “here” with “on F-Droid” makes the link purpose clear to screen-reader users and improves SEO. 👍
Proposed change
A new workflow has been added to the android repository to create a PR with an updated changelog. This PR add information about this new workflow.
Type of change
Checklist
Additional information
Summary by CodeRabbit