-
-
Notifications
You must be signed in to change notification settings - Fork 7.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Beoremote One documentation to Bang & Olufsen #37689
base: next
Are you sure you want to change the base?
Add Beoremote One documentation to Bang & Olufsen #37689
Conversation
✅ Deploy Preview for home-assistant-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
📝 WalkthroughWalkthroughThe documentation for the Bang & Olufsen integration has been updated to include detailed information about the new Beoremote One device. A new entry has been added, and additional sections document how the device pairs with Home Assistant, creates event entities, and triggers various types of key events (control functions, control keys, light functions, and light keys). Configuration instructions for adjusting light and control settings are also introduced, along with an explanation of potential issues when multiple Beoremote One devices trigger the same WebSocket notification. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant Remote as Beoremote One
participant HA as Home Assistant
participant WS as WebSocket Service
User->>Remote: Press key (e.g., control/light function)
Remote->>HA: Trigger creation of event entity
HA->>WS: Send event notification
Note over HA, WS: Event entities are initialized (disabled by default)
User->>Remote: Pair additional Beoremote One
Remote->>HA: Duplicate event trigger (potential conflict)
HA->>WS: Single notification for all paired devices
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (3)
source/_integrations/bang_olufsen.markdown (3)
104-107
: Addition of Beoremote One Event Handling Section.This new section explains that for each paired Beoremote One, a Home Assistant device is created and event entities (disabled by default) are generated for its compatible keys. Consider rephrasing “each of any paired Beoremote One” to something like “each paired Beoremote One device” for improved clarity and readability.
130-142
: Detailing Configuration of Light/Control Functions.The step-by-step guide for configuring the Light and Control submenus is thorough. A minor suggestion: consider rewording “show a list the paired devices” to “show a list of the paired devices” for grammatical clarity.
161-164
: Explaining Limitations for Paired Beoremote One Devices.This section under “### Beoremote One” describes how remote controls paired to the same device lead to duplicate event entities (up to 90 may be “lost”). It might be helpful to clarify what “lost” means in this context—e.g. that duplicate events may not trigger additional automations—and consider whether a subheading under the broader Limitations section would emphasize its context more clearly.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
source/_integrations/bang_olufsen.markdown
(4 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (3)
- GitHub Check: Redirect rules - home-assistant-docs
- GitHub Check: Header rules - home-assistant-docs
- GitHub Check: Pages changed - home-assistant-docs
🔇 Additional comments (3)
source/_integrations/bang_olufsen.markdown (3)
38-38
: New Beoremote One entry in Compatible Devices.A new bullet has been added for “Beoremote One” with a link to its product page and the note “through paired devices.” This clearly informs users how this device is integrated. Verify that “through paired devices” accurately reflects the operational details of the integration.
77-78
: Introduction of "Device controls" Header.The addition of the "#### Device controls" header under the Events section helps segregate event types for clarity. Confirm that its placement and hierarchy are consistent with other similar sections in the documentation.
107-127
: Clear "Triggering events" Documentation.The "##### Triggering events" subsection neatly lists the four different types of key events and explains how functions and keys are triggered. Ensure that the detailed instructions (using the
Right
andSelect
keys) align accurately with the remote’s behavior.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (4)
source/_integrations/bang_olufsen.markdown (4)
77-78
: Heading “Device controls” Review
The heading “#### Device controls” is introduced for the event documentation. Ensure that this heading clearly differentiates generic device control events from device-specific sections (such as Beoremote One later). If it fits the intended structure, no further changes are required.
104-129
: New “Beoremote One” Section for Events
This block introduces a detailed section for Beoremote One that explains the creation of Home Assistant devices per paired remote and the different key event types. The content is comprehensive and integrates well with the rest of the documentation.A couple of minor punctuation enhancements are suggested:
- Line 121: Consider adding a comma after “highlighted” for improved readability. For example:
-Keys can be triggered by pressing the `Select` key while either `Control` or `Light` are highlighted and then pressing one of the compatible keys. +Keys can be triggered by pressing the `Select` key while either `Control` or `Light` are highlighted, and then pressing one of the compatible keys.- Line 128: A comma after “In total” might improve clarity. For example:
-In total this amounts to 90 different remote key Event entities per remote. +In total, this amounts to 90 different remote key Event entities per remote.Overall, the documentation quality is high and clearly explains the event triggers and states.
🧰 Tools
🪛 LanguageTool
[uncategorized] ~121-~121: Possible missing comma found.
Context: ...y while eitherControl
orLight
are highlighted and then pressing one of the compatible...(AI_HYDRA_LEO_MISSING_COMMA)
[uncategorized] ~128-~128: Possible missing comma found.
Context: ... states: - key_press - key_release In total this amounts to 90 different remote key...(AI_HYDRA_LEO_MISSING_COMMA)
130-144
: Configuring Light / Control Functions Section
The configuration instructions for the Light and Control functions on the Beoremote One are detailed and easy to follow. Each step is clearly listed. Consider clarifying the reference to “Beovision” (line 137) by providing context or a brief note if this term might be unfamiliar to some users.
161-166
: Secondary “Beoremote One” Section – Multiple Remote Controls Note
The additional “### Beoremote One” section clarifies that several remotes can be paired and explains the limitation of 90 Event entities per Mozart device. This is useful information for users pairing multiple remotes.Additionally, a minor formatting improvement is noted:
- Line 163: There are trailing spaces detected. Please remove any unnecessary trailing whitespace to comply with markdown lint guidelines.
Overall, the content is clear and well integrated.
🧰 Tools
🪛 markdownlint-cli2 (0.17.2)
163-163: Trailing spaces
Expected: 0 or 2; Actual: 1(MD009, no-trailing-spaces)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
source/_integrations/bang_olufsen.markdown
(4 hunks)
🧰 Additional context used
🪛 LanguageTool
source/_integrations/bang_olufsen.markdown
[uncategorized] ~121-~121: Possible missing comma found.
Context: ...y while either Control
or Light
are highlighted and then pressing one of the compatible...
(AI_HYDRA_LEO_MISSING_COMMA)
[uncategorized] ~128-~128: Possible missing comma found.
Context: ... states: - key_press - key_release In total this amounts to 90 different remote key...
(AI_HYDRA_LEO_MISSING_COMMA)
🪛 markdownlint-cli2 (0.17.2)
source/_integrations/bang_olufsen.markdown
163-163: Trailing spaces
Expected: 0 or 2; Actual: 1
(MD009, no-trailing-spaces)
🔇 Additional comments (1)
source/_integrations/bang_olufsen.markdown (1)
38-38
: New Device Entry Added
The new Beoremote One entry in the “Compatible devices” list is clear and follows the established format. This addition provides a direct link and context by mentioning it is added “through paired devices.”
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (3)
source/_integrations/bang_olufsen.markdown (3)
77-78
: Clarify “Mozart device controls” HeadingThe heading “Mozart device controls” is introduced just before detailing event entities. Please ensure that its role is clearly distinguished from the upcoming device-specific section for Beoremote One so that readers easily understand which controls apply to which part of the integration.
130-139
: Verify Configuration Instructions for Light / Control FunctionsThe “##### Configuring Light / Control functions” section provides clear, step‐by‐step guidance. However, the instruction to “Select
Beovision
” appears ambiguous in this context. Please verify that “Beovision” is the correct label for the paired device list or intended option. If there is a naming discrepancy, updating it could help avoid user confusion.
161-163
: Clarify Limitations When Pairing Multiple Beoremote One RemotesThe new section under “### Beoremote One” (post-limitations) appropriately warns that multiple paired remotes trigger the same WebSocket notification, resulting in a fixed set of 90 event entities per device. This important limitation is well noted; consider elaborating further on its practical implications or potential workarounds for advanced users if needed.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
source/_integrations/bang_olufsen.markdown
(4 hunks)
🔇 Additional comments (2)
source/_integrations/bang_olufsen.markdown (2)
38-38
: Addition of Beoremote One Device EntryThe new device entry for Beoremote One is clearly added with an accurate link and description. Please verify that the URL remains up-to-date with the latest product page.
104-112
: Detailed Beoremote One Section AddedThe new “#### Beoremote One” section nicely explains that each paired remote is represented as a Home Assistant device, with event entities created (disabled by default) for each compatible key. The breakdown of the four key event types is clear and aligns with the intended documentation enhancements.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @mj23000 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (6)
source/_integrations/bang_olufsen.markdown (6)
38-38
: Device Listing Update
The new bullet for Beoremote One is correctly added with the proper link. However, the appended text “through paired devices” slightly deviates from the styling of the other device entries. Consider either omitting the extra phrase or clarifying its purpose (for example, by adding a tooltip or brief note later) so that the list maintains a consistent style.
77-103
: Clarify Section Distinction Between Device Controls
The “#### Mozart device controls” section (lines 77–103) remains in the Events area alongside the new Beoremote One sections. It would be beneficial to explicitly differentiate these two parts. For instance, you might add a brief note explaining that while generic Mozart devices support multiple event types (e.g. short/long presses), Beoremote One remotes are documented separately with a simplified event model. This additional context can help avoid confusion for users reading the documentation.
104-108
: Introduction to Beoremote One Section
The new “#### Beoremote One” header and its introductory description clearly explain that a Home Assistant device is created for each Beoremote One paired via its Mozart device. For clarity and consistency, consider rephrasing the opening sentence. For example:“A Home Assistant device is created for each Beoremote One paired through a Mozart device. Event entities are automatically generated for each compatible key on the remote and are disabled by default.”
This rewording may help ensure that the process is immediately understandable.
110-123
: Clarify Triggering Events Instructions
The “##### Triggering events” section outlines that there are 4 different key event types and that each trigger produces two event states. Two points to consider:
- The lines beginning with “Functions can be accessed by pressing the
Right
key…” (line 119) and “Keys can be triggered by pressing theSelect
key…” (line 121) seem slightly redundant. Merging or clarifying the difference between accessing available functions and triggering a key might improve clarity.- The sentence “Each of these triggers have two different event states:” should be revised for subject–verb agreement. For example:
“Each of these triggers has two different event states:”
A brief note explaining why Beoremote One remotes only support the simplified two-state model (key_press and key_release) compared to the more detailed set in the generic controls section could also be useful.
130-143
: Configuration Instructions Review
The “##### Configuring light and control functions” section provides clear, step‐by‐step instructions. These directions are consistent with other parts of the documentation. To further improve clarity, you might consider adding a short note that specifies any preconditions (for example, ensuring the remote is fully paired) before accessing these settings.
161-163
: Clarify Multiple Remote Pairing Limitations
The added “### Beoremote One” section under Limitations effectively highlights that several remotes can be paired to a single Mozart device and that they share the same WebSocket notifications. For added clarity, consider explicitly stating that a Mozart device supports a maximum of 90 event entities regardless of how many Beoremote One remotes are paired. This clarification will help prevent any potential confusion regarding the scalability or behavior of the integration.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
source/_integrations/bang_olufsen.markdown
(4 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (3)
- GitHub Check: Redirect rules - home-assistant-docs
- GitHub Check: Header rules - home-assistant-docs
- GitHub Check: Pages changed - home-assistant-docs
Proposed change
Add documentation for the Beoremote One
Type of change
current
branch).current
branch).next
branch).next
branch).Additional information
Checklist
current
branch.next
branch.Summary by CodeRabbit