Skip to content

Cleanup backup model after changes #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 29, 2025
Merged

Cleanup backup model after changes #47

merged 2 commits into from
Jan 29, 2025

Conversation

mdegat01
Copy link
Collaborator

Proposed Changes

The new location_attributes field makes a lot of other information in the backup model redundant. In addition we now have an inconsistency where sometimes we use .local and sometimes we use None to represent local storage. Remove all the redundant fields and switch to .local everywhere.

Since specifying None as a location is no longer supported in the request and the size, size_bytes and location fields are removed this is a breaking change.

@mdegat01 mdegat01 added breaking-change A breaking change for existing users. refactor Improvement of existing code, not introducing new features. labels Jan 28, 2025
@mdegat01 mdegat01 requested a review from agners January 28, 2025 15:22
agners
agners reviewed Jan 28, 2025
View reviewed changes
Copy link
Collaborator

@agners agners left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Upload and download backup currently still convert None to "" (local, e.g. upload_backup). Should we maybe remove this implicit conversation too? And/or use .local 🤔

@agners agners merged commit 2a0dc39 into main Jan 29, 2025
7 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 31, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@agners agners agners approved these changes

Assignees
No one assigned
Labels
breaking-change A breaking change for existing users. refactor Improvement of existing code, not introducing new features.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mdegat01 @agners
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy