Skip to content

latest <- beta #3635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 0 commits into from
Closed

latest <- beta #3635

wants to merge 0 commits into from

Conversation

bwp91
Copy link
Contributor

@bwp91 bwp91 commented Jun 24, 2024 •
edited
Loading

Breaking Changes

  • Before Upgrading you will want to make sure that the plugin(s) you are using are up to date and are not usng deprecated code
    • If you are unsure open an issue with the developer of your plugin(s) in question.
  • We have removed deprecated old Homebridge code
  • HAP-NodeJS v1.0.0 is included in this release. In v1.0.0 we have removed old deprecated code.

Changes For Developers

  • Because of the Breaking Changes in HAP-NodeJS v1.0.0, there may be some changes that you will have to make to your plugins.
    • Common long-deprecated code patterns that may need updating:
      • Use of enums off the HAP API object are not support.
      • Examples:
        • Instead of const Units = Characteristic.Units; you will need to use const Units = api.hap.Units;
        • Instead of const Formats = Characteristic.Formats; you will need to use const Formats = api.hap.Formats;
        • Instead of const Perms = Characteristic.Perms; you will need to use const Perms = api.hap.Perms;

Fixed

Changed

Homebridge Dependencies

  • hap-nodejs @ v1.0.0

@coveralls
Copy link

coveralls commented Jun 24, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9649379062

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 28.009%
Totals Coverage Status
Change from base Build 9626810783: 0.0%
Covered Lines: 426
Relevant Lines: 1374
💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 24, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9649421726

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 28.009%
Totals Coverage Status
Change from base Build 9626810783: 0.0%
Covered Lines: 426
Relevant Lines: 1374
💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 25, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9655066281

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 28.009%
Totals Coverage Status
Change from base Build 9626810783: 0.0%
Covered Lines: 426
Relevant Lines: 1374
💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 25, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9670752873

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 28.009%
Totals Coverage Status
Change from base Build 9626810783: 0.0%
Covered Lines: 426
Relevant Lines: 1374
💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 26, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9672545468

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 28.009%
Totals Coverage Status
Change from base Build 9626810783: 0.0%
Covered Lines: 426
Relevant Lines: 1374
💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 26, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9672594524

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 28.009%
Totals Coverage Status
Change from base Build 9626810783: 0.0%
Covered Lines: 426
Relevant Lines: 1374
💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 29, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9723748606

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 28.009%
Totals Coverage Status
Change from base Build 9626810783: 0.0%
Covered Lines: 426
Relevant Lines: 1374
💛 - Coveralls

@coveralls
Copy link

coveralls commented Jul 4, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9799663577

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 28.009%
Totals Coverage Status
Change from base Build 9626810783: 0.0%
Covered Lines: 426
Relevant Lines: 1374
💛 - Coveralls

@coveralls
Copy link

coveralls commented Jul 6, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9816523367

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 28.009%
Totals Coverage Status
Change from base Build 9815963764: 0.0%
Covered Lines: 426
Relevant Lines: 1374
💛 - Coveralls

@coveralls
Copy link

coveralls commented Jul 6, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9818519066

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 28.009%
Totals Coverage Status
Change from base Build 9815963764: 0.0%
Covered Lines: 426
Relevant Lines: 1374
💛 - Coveralls

@coveralls
Copy link

coveralls commented Jul 6, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9819500216

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 28.178%
Totals Coverage Status
Change from base Build 9819412404: 0.0%
Covered Lines: 426
Relevant Lines: 1366
💛 - Coveralls

@coveralls
Copy link

coveralls commented Jul 6, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9821915202

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 28.178%
Totals Coverage Status
Change from base Build 9819412404: 0.0%
Covered Lines: 426
Relevant Lines: 1366
💛 - Coveralls

@coveralls
Copy link

coveralls commented Jul 9, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9912805310

Details

  • 0 of 19 (0.0%) changed or added relevant lines in 2 files are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.3%) to 27.83%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/plugin.ts 0 2 0.0%
src/bridgeService.ts 0 17 0.0%
Files with Coverage Reduction New Missed Lines %
src/index.ts 3 0.0%
Totals Coverage Status
Change from base Build 9819412404: -0.3%
Covered Lines: 416
Relevant Lines: 1350
💛 - Coveralls

@grzegorz914
Copy link

grzegorz914 commented Jul 11, 2024 •
edited
Loading

Latest beta.16 with HAP 1.0 break my custom characteristics,

const Service = api.hap.Service;
  const Characteristic = api.hap.Characteristic;
  const Units = Characteristic.Units;
  const Formats = Characteristic.Formats;
  const Perms = Characteristic.Perms;

  //Envoy
  class enphaseEnvoyAlerts extends Characteristic {
    constructor() {
      super('Alerts', '00000001-000B-1000-8000-0026BB765291');
      this.setProps({
        format: Formats.STRING,
        perms: [Perms.READ, Perms.NOTIFY]
      });
      this.value = this.getDefaultValue();
    }
  }
  Characteristic.enphaseEnvoyAlerts = enphaseEnvoyAlerts;

Prepare accessory error: TypeError: Cannot read properties of undefined (reading 'STRING'

@donavanbecker
Copy link
Contributor

Latest beta.16 with HAP 1.0 break my custom characteristics,


const Service = api.hap.Service;

  const Characteristic = api.hap.Characteristic;

  const Units = Characteristic.Units;

  const Formats = Characteristic.Formats;

  const Perms = Characteristic.Perms;



  //Envoy

  class enphaseEnvoyAlerts extends Characteristic {

    constructor() {

      super('Alerts', '00000001-000B-1000-8000-0026BB765291');

      this.setProps({

        format: Formats.STRING,

        perms: [Perms.READ, Perms.NOTIFY]

      });

      this.value = this.getDefaultValue();

    }

  }

  Characteristic.enphaseEnvoyAlerts = enphaseEnvoyAlerts;

Prepare accessory error: TypeError: Cannot read properties of undefined (reading 'STRING'

Please open an issue on the hap-nodejs or Homebridge repo with a Homebridge plugin to reference and the line of code effected, thanks!

@bwp91 bwp91 closed this Jul 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
latest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bwp91 @coveralls @grzegorz914 @donavanbecker
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy