Skip to content

updates to lint, tests and build #3681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 29, 2024
Merged

updates to lint, tests and build #3681

merged 4 commits into from
Aug 29, 2024

Conversation

bwp91
Copy link
Contributor

@bwp91 bwp91 commented Aug 24, 2024

No description provided.

@github-actions github-actions bot added the beta label Aug 24, 2024
@coveralls
Copy link

coveralls commented Aug 24, 2024

Pull Request Test Coverage Report for Build 10610891392

Details

  • 418 of 1251 (33.41%) changed or added relevant lines in 16 files are covered.
  • 445 unchanged lines in 13 files lost coverage.
  • Overall coverage increased (+9.7%) to 37.53%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/platformAccessory.ts 38 41 92.68%
src/ipcService.ts 12 16 75.0%
src/storageService.ts 5 14 35.71%
src/externalPortService.ts 5 19 26.32%
src/api.ts 38 60 63.33%
src/cli.ts 0 64 0.0%
src/plugin.ts 10 87 11.49%
src/childBridgeFork.ts 0 114 0.0%
src/pluginManager.ts 73 188 38.83%
src/bridgeService.ts 46 178 25.84%
Files with Coverage Reduction New Missed Lines %
src/index.ts 1 0.0%
src/platformAccessory.ts 1 95.88%
src/ipcService.ts 4 73.68%
src/storageService.ts 7 58.14%
src/externalPortService.ts 9 37.78%
src/cli.ts 12 0.0%
src/api.ts 13 65.49%
src/pluginManager.ts 49 44.53%
src/plugin.ts 49 7.05%
src/childBridgeFork.ts 54 0.0%
Totals Coverage Status
Change from base Build 10234080398: 9.7%
Covered Lines: 755
Relevant Lines: 2256

💛 - Coveralls

donavanbecker
donavanbecker previously approved these changes Aug 25, 2024
README.md Outdated
@@ -16,19 +16,19 @@

<img src="https://media.giphy.com/media/10l79ICohTu4iQ/giphy.gif" align="right" alt="Unlocking Door">

**Homebridge** is a lightweight Node.js server you can run on your home network that emulates the iOS HomeKit API. It supports Plugins, which are community-contributed modules that provide a basic bridge from HomeKit to various 3rd-party APIs provided by manufacturers of "smart home" devices.
**Homebridge** is a lightweight Node.js server you can run on your home network that emulates the iOS HomeKit API. It supports Plugins, which are community-contributed modules that provide a basic bridge from HomeKit to various 3rd-party APIs provided by manufacturers of "smart home" devices.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That’s actually incorrect. It emulates the HomeKit Accessory Protocol.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is doubly untrue because my home network does not emulate either HomeKit Accessory Protocol or iOS HomeKit API 😋😋😋 (it's about sentence order 😉).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you also have a point, but I'd better leave the sentence order to the native speakers ;-)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated to:

Homebridge is a lightweight Node.js server you can run on your home network to emulate the HomeKit Accessory Protocol (HAP).

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect! 👍

@bwp91 bwp91 merged commit 76d8cf3 into beta-2.0.0 Aug 29, 2024
12 checks passed
@bwp91 bwp91 deleted the alpha-2.0.0 branch August 29, 2024 07:51
bwp91 added a commit that referenced this pull request Jun 8, 2025
bwp91 added a commit that referenced this pull request Jun 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy