Improve STL exercise #222
Merged
Improve STL exercise #222
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
bernhardmgruber
commented
Aug 12, 2022
- Prefix STL calls with std::
- Add const to variables with are not mutated
- Add lambda based alternative solution
* Prefix STL calls with std:: * Add const to variables with are not mutated * Add lambda based alternative solution
2 tasks
hageboeck
requested changes
Aug 12, 2022
Comment on lines
+44
to
+45
| const T sum = std::reduce(diffs.begin()+1, diffs.end(), T()); | ||
| const T sumsq = std::reduce(diffs.begin()+1, diffs.end(), T(), sumsquare<T>()); |
There was a problem hiding this comment.
Suggested change
| const T sum = std::reduce(diffs.begin()+1, diffs.end(), T()); | |
| const T sumsq = std::reduce(diffs.begin()+1, diffs.end(), T(), sumsquare<T>()); | |
| const T sum = std::reduce(diffs.begin(), diffs.end(), T()); | |
| const T sumsq = std::reduce(diffs.begin(), diffs.end(), T(), sumsquare<T>()); |
Why do you skip the first element? Was this meant to be
const T sum = std::reduce(diffs.begin(), diffs.end(), diffs[0]);?
There was a problem hiding this comment.
I think this is correct, since std::adjacent_difference only writes differences starting at element 1. So diffs[0] is just v[0] and diffs[1] is the first difference (v[1] - v[0]).
There was a problem hiding this comment.
Sorry, I ignored where those values came from. This is correct, but not very intuitive without any explanation.
There was a problem hiding this comment.
With your suggestions (that I committed), this is resolved now I guess?
hageboeck
reviewed
Aug 12, 2022
hageboeck
reviewed
Aug 12, 2022
Co-authored-by: Stephan Hageboeck <stephan.hageboeck@cern.ch>
Co-authored-by: Stephan Hageboeck <stephan.hageboeck@cern.ch>
hageboeck
approved these changes
Aug 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.