Skip to content

Fix CS and PHPStan #1938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 20, 2023
Merged

Fix CS and PHPStan #1938

merged 2 commits into from
Aug 20, 2023

Conversation

Seb33300
Copy link
Contributor

@Seb33300 Seb33300 commented Jun 22, 2023 •
edited
Loading

  • Run PHP-CS-Fixer
  • Fix new PHPStan issues

@Seb33300 Seb33300 changed the title Fix CS Fix CI Jun 22, 2023
@Seb33300
Copy link
Contributor Author

I am not able to find a solution to fix failing tests on Symfony 6

Looks related to lexik/LexikJWTAuthenticationBundle#1143

Something is starting the session on stateless pages but I was not able to find what.

@Seb33300 Seb33300 changed the title Fix CI Fix CS and PHPStan Jun 22, 2023
@Seb33300 Seb33300 mentioned this pull request Aug 9, 2023
Closed
@Seb33300
Copy link
Contributor Author

Tests on PHP 8.1 should be fixed by symfony/symfony#51350

@stloyd stloyd merged commit 5ec59cd into hwi:master Aug 20, 2023
@Seb33300 Seb33300 deleted the fix-cs branch August 20, 2023 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stloyd stloyd stloyd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Seb33300 @stloyd
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy