Skip to content

Release/automate remediation #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Jul 4, 2025
Merged

Conversation

iKnowJavaScript
Copy link
Owner

This pull request introduces significant updates to the AWS remediation module, including enhancements to configuration flexibility, support for scheduled remediation, and compatibility updates for newer AWS provider and Lambda runtime versions. Below is a summary of the most important changes grouped by theme.

Configuration Enhancements

  • Renamed lambda_zip to path_to_lambda_zip for clarity and updated references across README.md, main.tf, and variables.tf. [1] [2] [3]
  • Changed remediation_options from a single object to a list of objects, allowing multiple remediation configurations. Updated associated validation rules. [1] [2]
  • Added remediation_schedule_days and ssn_notification_topic_arn variables to support scheduled remediation and optional SNS notifications. [1] [2]

Scheduling and Event Handling

  • Replaced the single EventBridge rule for Inspector findings with a dynamic schedule-based approach using remediation_schedule_days. Each schedule triggers remediation for the specified configurations.
  • Added support for optional SNS notifications for remediation events if ssn_notification_topic_arn is provided. [1] [2]

Compatibility Updates

  • Upgraded the AWS provider version requirement from ~> 4.0 to ~> 5.0 in versions.tf and examples/basic/terraform.tf. [1] [2]
  • Updated the Lambda runtime from nodejs18.x to nodejs20.x in main.tf.

IAM Policy Adjustments

  • Scoped IAM policies more tightly by replacing wildcard resources with specific ARNs for logs, SSM, and Inspector services. [1] [2]

Example Updates

  • Updated the example in examples/basic/main.tf to reflect the new variable names, list-based remediation_options, and added scheduling configurations.

These changes improve the module's flexibility, security, and compatibility, while also introducing new features for automated and scheduled remediation.

@iKnowJavaScript iKnowJavaScript self-assigned this Jul 4, 2025
Copy link
Contributor

@gomboc-ai-community gomboc-ai-community bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I scanned the examples/basic directory in search of Terraform misconfigurations. No issues found!

@gomboc-ai-community gomboc-ai-community bot mentioned this pull request Jul 4, 2025
gomboc-ai-community bot and others added 3 commits July 4, 2025 22:46
Co-authored-by: gomboc-ai-community[bot] <215871000+gomboc-ai-community[bot]@users.noreply.github.com>
@iKnowJavaScript iKnowJavaScript merged commit 3bf3b17 into main Jul 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy