This repository was archived by the owner on Jan 17, 2025. It is now read-only.
Do not rebuild image for publish. #98
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
falkzoll
commented
Oct 19, 2022
- Avoid to rebuild the image before pushing it to the image repository. The distDocker target does an docker build before tagging and pushing to the image repository. Depending on how the docker cache is used, this causes a full rebuild of the image. But we want to push the already built and tested image not a newly created one. Therefore we now use the pushImage target. It only does a tag and a push without a docker build. In case the image does not exist (no build before), it will fail.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.