Skip to content

fix: Aggregation function in LINQ expressions #510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 27, 2023
Merged

fix: Aggregation function in LINQ expressions #510

merged 4 commits into from
Apr 27, 2023

Conversation

bednar
Copy link
Contributor

@bednar bednar commented Apr 27, 2023 •
edited
Loading

Closes #461

Proposed Changes

Fixed passing aggregation function to AggregateWindow.

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • A test has been added if appropriate
  • dotnet test completes successfully
  • Commit messages are conventional
  • Sign CLA (if not already signed)

@bednar bednar added this to the 4.12.0 milestone Apr 27, 2023
@bednar bednar added the bug Something isn't working label Apr 27, 2023
@bednar bednar requested a review from Sciator April 27, 2023 09:03
@bednar bednar mentioned this pull request Apr 27, 2023
Closed
@bednar bednar marked this pull request as ready for review April 27, 2023 09:06
Sciator
Sciator approved these changes Apr 27, 2023
View reviewed changes
Copy link
Contributor

@Sciator Sciator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bednar bednar merged commit 7391962 into master Apr 27, 2023
@bednar bednar deleted the aggregation-window-fn branch April 27, 2023 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sciator Sciator Sciator approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
4.12.0
Development

Successfully merging this pull request may close these issues.
2 participants
@bednar @Sciator
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy