Timer task is disposed due to `restartTimerOnMaxSize` leading to data loss

__Steps to reproduce:__
1. Submit data fast enough,
2. If timer is running while buffer is full ,timer task will be disposed.

We can see it in :
https://github.com/influxdata/influxdb-client-java/blob/d641b1163986f90dbcc2d1275fceff698636882d/client/src/main/java/com/influxdb/client/internal/flowable/FlowableBufferTimedFlushable.java#L156-L196


This bug will lead to #793. I think setting `restartTimerOnMaxSize` to false will be a good choice. Or we can add a flag when task is running and do not dispose the timer task.




__Specifications:__
 - Client Version: 6.7.0
 - InfluxDB Version: 2.6.1
 - JDK Version: 11
 - Platform: linux

	public void onNext(T t) {
	U b;
	synchronized (this) {
	b = buffer;
	if (b == null) {
	return;
	}

	b.add(t);

	if (b.size() < maxSize) {
	return;
	}

	buffer = null;
	producerIndex++;
	}

	if (restartTimerOnMaxSize) {
	timer.dispose();
	}

	fastPathOrderedEmitMax(b, false, this);

	try {
	b = Objects.requireNonNull(bufferSupplier.get(), "The supplied buffer is null");
	} catch (Throwable e) {
	Exceptions.throwIfFatal(e);
	cancel();
	downstream.onError(e);
	return;
	}

	synchronized (this) {
	buffer = b;
	consumerIndex++;
	}
	if (restartTimerOnMaxSize) {
	timer = w.schedulePeriodically(this, timespan, timespan, unit);
	}
	}

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Timer task is disposed due to `restartTimerOnMaxSize` leading to data loss #806

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Timer task is disposed due to restartTimerOnMaxSize leading to data loss #806

Description

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Timer task is disposed due to `restartTimerOnMaxSize` leading to data loss #806