Skip to content

feat(authorization): add possibility to use *Request object in wrapped API #457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 25, 2022
Merged

feat(authorization): add possibility to use *Request object in wrapped API #457

merged 2 commits into from
Oct 25, 2022

Conversation

bednar
Copy link
Contributor

@bednar bednar commented Oct 25, 2022 •
edited
Loading

Closes #453

Proposed Changes

This PR add possibility to use AuthorizationPostRequest and AuthorizationUpdateRequest in wrapped API - AuthorizationApi.

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • A test has been added if appropriate
  • mvn test completes successfully
  • Commit messages are conventional
  • Sign CLA (if not already signed)

@codecov-commenter
Copy link

codecov-commenter commented Oct 25, 2022 •
edited
Loading

Codecov Report

Base: 88.40% // Head: 88.40% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (fd050c1) compared to base (9ce5275).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files 
@@            Coverage Diff            @@
##             master     #457   +/-   ##
=========================================
  Coverage     88.40%   88.40%           
- Complexity      776      777    +1     
=========================================
  Files           172      172           
  Lines          7010     7014    +4     
  Branches        378      378           
=========================================
+ Hits           6197     6201    +4     
  Misses          693      693           
  Partials        120      120
Impacted Files Coverage Δ
...nfluxdb/client/internal/AuthorizationsApiImpl.java 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@bednar bednar marked this pull request as ready for review October 25, 2022 08:02
@bednar bednar requested a review from vlastahajek October 25, 2022 08:21
vlastahajek
vlastahajek approved these changes Oct 25, 2022
View reviewed changes
Copy link

@vlastahajek vlastahajek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@bednar bednar merged commit f137cd9 into master Oct 25, 2022
@bednar bednar deleted the authorization_allow_to_use_request_objects branch October 25, 2022 10:29
@bednar bednar added this to the 6.7.0 milestone Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vlastahajek vlastahajek vlastahajek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
6.7.0
Development

Successfully merging this pull request may close these issues.

Missing setter method Authorization.setUserID(String)?
3 participants
@bednar @codecov-commenter @vlastahajek
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy