Skip to content

chore: added check to code style, added check to correct PyPI documentation #126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Jul 9, 2020
Merged

chore: added check to code style, added check to correct PyPI documentation #126

merged 10 commits into from
Jul 9, 2020

Conversation

bednar
Copy link
Contributor

@bednar bednar commented Jul 7, 2020

  1. Added check to code style:
    1. https://circleci.com/gh/influxdata/influxdb-client-python/1073?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link
    2. Fixed sources to satisfy code style
    3. Configure flake8 by tox.ini
  2. Added check to PyPi documentation:
    1. https://circleci.com/gh/influxdata/influxdb-client-python/1072?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link
  3. Fixed inheritance for Threshold domain object
  • Rebased/mergeable
  • Tests pass
  • Sign CLA (if not already signed)

@bednar bednar requested a review from rhajek July 7, 2020 14:33
@bednar bednar added the ci label Jul 7, 2020
@codecov-commenter
Copy link

Codecov Report

Merging #126 into master will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #126      +/-   ##
==========================================
- Coverage   88.73%   88.71%   -0.02%     
==========================================
  Files          23       22       -1     
  Lines        1829     1826       -3     
==========================================
- Hits         1623     1620       -3     
  Misses        206      206
Impacted Files Coverage Δ
influxdb_client/client/influxdb_client.py 98.27% <100.00%> (ø)
influxdb_client/client/write_api.py 96.62% <100.00%> (-0.02%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c167e9...f006b49. Read the comment docs.

bednar added a commit to influxdata/influxdb-clients-apigen that referenced this pull request Jul 9, 2020
@bednar
fix: python codestyle (influxdata/influxdb-client-python#126)
473b5cb
@bednar bednar mentioned this pull request Jul 9, 2020
Closed
@rhajek rhajek merged commit 5c39813 into master Jul 9, 2020
@bednar bednar deleted the fix/code-style branch July 9, 2020 11:54
@bednar bednar added this to the 1.9.0 milestone Jul 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhajek rhajek rhajek approved these changes

Assignees
No one assigned
Labels
ci
Projects
None yet
Milestone
1.9.0
Development

Successfully merging this pull request may close these issues.
3 participants
@bednar @codecov-commenter @rhajek
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy