Skip to content

fix: serialize numpy floats #254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 19, 2021
Merged

fix: serialize numpy floats #254

merged 3 commits into from
May 19, 2021

Conversation

bednar
Copy link
Contributor

@bednar bednar commented May 13, 2021

Closes #252

Proposed Changes

Fixed serializing numpy float types into Line Protocol.

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • A test has been added if appropriate
  • pytest tests completes successfully
  • Commit messages are in semantic format
  • Sign CLA (if not already signed)

@bednar bednar marked this pull request as ready for review May 13, 2021 08:40
@bednar bednar requested a review from rhajek May 13, 2021 08:40
@codecov-commenter
Copy link

codecov-commenter commented May 13, 2021

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.93%. Comparing base (bccc2b8) to head (0e6978a).
Report is 239 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #254   +/-   ##
=======================================
  Coverage   91.93%   91.93%           
=======================================
  Files          25       25           
  Lines        2033     2033           
=======================================
  Hits         1869     1869           
  Misses        164      164           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bednar bednar merged commit a421a6f into master May 19, 2021
@bednar bednar deleted the fix/serialize-np-floats branch May 19, 2021 11:41
@bednar bednar added this to the 1.18.0 milestone May 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Field type is set to string when writing float32 type from Pandas DataFrame
3 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy