Skip to content

Added an option to enable dropping of new points written after action queue exhaustion. #689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jul 20, 2020

Conversation

simarpreets
Copy link
Contributor

Fix for #688

…sor#queue is exhausted.

2. Added an option to plug in a handler which will be invoked if above happens.
@majst01
Copy link
Collaborator

majst01 commented Jul 16, 2020

Build fails because of checkstyle errors, if these are fixed i can start reviewing

@codecov-commenter
Copy link

codecov-commenter commented Jul 17, 2020

Codecov Report

Merging #689 into master will increase coverage by 0.04%.
The diff coverage is 93.10%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #689      +/-   ##
============================================
+ Coverage     88.18%   88.22%   +0.04%     
- Complexity      722      729       +7     
============================================
  Files            69       69              
  Lines          2513     2540      +27     
  Branches        268      269       +1     
============================================
+ Hits           2216     2241      +25     
- Misses          208      210       +2     
  Partials         89       89              
Impacted Files Coverage Δ Complexity Δ
src/main/java/org/influxdb/BatchOptions.java 94.91% <90.90%> (-0.92%) 24.00 <4.00> (+4.00) ⬇️
...rc/main/java/org/influxdb/impl/BatchProcessor.java 97.97% <92.30%> (-0.56%) 22.00 <5.00> (+3.00) ⬇️
src/main/java/org/influxdb/impl/InfluxDBImpl.java 82.50% <100.00%> (+0.16%) 82.00 <1.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 027b62e...035b13b. Read the comment docs.

@simarpreets
Copy link
Contributor Author

@majst01 CI build is passing now, please review.

@majst01
Copy link
Collaborator

majst01 commented Jul 17, 2020

LGTM, can you please add a Changelog entry and a section in the MANUAL.md with an useful example ?

@simarpreets
Copy link
Contributor Author

simarpreets commented Jul 19, 2020

@majst01 Added a changelog entry and update MANUAL.md.
CI build failed because of an unrelated reason(seems like a network issue), will trigger it again after a while.

@majst01 majst01 merged commit f590c59 into influxdata:master Jul 20, 2020
@majst01
Copy link
Collaborator

majst01 commented Jul 20, 2020

@simarpreets Thanks for your contribution !

@simarpreets
Copy link
Contributor Author

@majst01 when are you planning to release this?

@sjoshid
Copy link

sjoshid commented Sep 30, 2020

I think this is important change but can I nitpick?? What is the need for dropActionsOnQueueExhaustion boolean? I would have preferred to just have droppedActionHandler.

If droppedActionHandler is set, dropActionsOnQueueExhaustion is true. If null dropActionsOnQueueExhaustion is false. I hate having this separate flag that is meaningless.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy