-
Notifications
You must be signed in to change notification settings - Fork 477
Added an option to enable dropping of new points written after action queue exhaustion. #689
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…sor#queue is exhausted. 2. Added an option to plug in a handler which will be invoked if above happens.
Build fails because of checkstyle errors, if these are fixed i can start reviewing |
Codecov Report
@@ Coverage Diff @@
## master #689 +/- ##
============================================
+ Coverage 88.18% 88.22% +0.04%
- Complexity 722 729 +7
============================================
Files 69 69
Lines 2513 2540 +27
Branches 268 269 +1
============================================
+ Hits 2216 2241 +25
- Misses 208 210 +2
Partials 89 89
Continue to review full report at Codecov.
|
@majst01 CI build is passing now, please review. |
LGTM, can you please add a Changelog entry and a section in the MANUAL.md with an useful example ? |
@majst01 Added a changelog entry and update MANUAL.md. |
@simarpreets Thanks for your contribution ! |
@majst01 when are you planning to release this? |
I think this is important change but can I nitpick?? What is the need for If |
Fix for #688