This repository was archived by the owner on Oct 29, 2024. It is now read-only.
Pythonic changes #133
Merged
Pythonic changes #133
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
March 25, 2015 09:48
Caller has not to give us that.
|
Thank you for contributing :) |
|
damn, the |
|
erf, you already merged, ok no prob doing another pr ;) |
|
hehe, indeed it is! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some/few pythonic (mostly obvious) changes.
The greater is the change to dataframe_client, I split it up in 2 files for cleaner separation ;
_dataframe_client.pyis now in fact the "real"/usable one : it completely assumes that pandas is available. whiledataframe_client.pysimply wraps it but providing a fallback (as previously) DataFrameClient class which does the same thing (as previously) in case pandas isn't available/usable.