Skip to content
This repository was archived by the owner on Oct 29, 2024. It is now read-only.

Revert "Revert "Sync tests against last master update"" #158

Merged
merged 3 commits into from
Apr 21, 2015

Conversation

gst
Copy link
Contributor

@gst gst commented Apr 13, 2015

This reverts commit d3bb67d.

This commit was "good" :

  • it slightly simplified the server setup & launch
  • and it also fix the webui port (was missing) (And more important this makes it possible to test against the last server RC (rc23)).

@aviau
Copy link
Collaborator

aviau commented Apr 13, 2015

Waitint for Travis

@gst
Copy link
Contributor Author

gst commented Apr 13, 2015

and it also fix the webui port (was missing) (And more important this makes it possible to test against the last server RC (rc23)).

though, they have added some info in the response in case of db not previously existing :

AssertionError: '{"results":[{"error":"database not found"}]}' != u'{"results":[{"error":"database not found: db (/home/gstarck/go/src/github.com/influxdb/influxdb/server.go:1010)"}]}'

.. grrr.. will have to adapt the assert..

@gst
Copy link
Contributor Author

gst commented Apr 13, 2015

AssertionError: '{"results":[{"error":"database not found"}]}' != u'{"results":[{"error":"database not found: db (/home/gstarck/go/src/github.com/influxdb/influxdb/server.go:1010)"}]}'

.. grrr.. will have to adapt the assert..

we will see when we'll update the server-RC we use ;)

@aviau
Copy link
Collaborator

aviau commented Apr 18, 2015

@gst You can go ahead and update it in the .travis.yml

@gst gst force-pushed the fix_server_config_template branch from 2360356 to 43550b3 Compare April 20, 2015 14:29
@gst
Copy link
Contributor Author

gst commented Apr 20, 2015

rebased on master.

But they may change again that response content before final release :
https://groups.google.com/forum/#!topic/influxdb/YO0bKLV9Zfs

so we can just wait that they do that ;)

@aviau
Copy link
Collaborator

aviau commented Apr 20, 2015

@gst You have python 3.2 failing. Should be an easy-fix.

That may still change in final release..
@gst gst force-pushed the fix_server_config_template branch from 1f00396 to 39d61c6 Compare April 20, 2015 17:55
aviau added a commit that referenced this pull request Apr 21, 2015
Revert "Revert "Sync tests against last master update""
@aviau aviau merged commit c087659 into influxdata:master Apr 21, 2015
@aviau aviau deleted the fix_server_config_template branch April 21, 2015 18:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy