This repository was archived by the owner on Oct 29, 2024. It is now read-only.
Support for Line Protocol #209
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
as introduced in influxdata/influxdb#2696
Working again with influxdata/influxdb@246ce61 Signed-off-by: Petr Štetiar <ynezz@true.cz>
|
Thank you for your PR :) I intend to take a look at it in the next few days. |
|
I have merged this and rebased in the line_protocol branch. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So this is what I have. THIS IS NOT COMPLETE, MORE WORK WILL BE REQUIRED.
There are a few test failures left. I haven't even tested this manually against a real InfluxDB instance.
Some of the fixed test cases should be closely reviewed (probably along with all the other stuff that is currently skipped because it's known to break with 0.9.0). New tests might also be required.
Sorry to leave this so messy, but I don't have any time left to commit to this effort so... take it or leave it. I think
line_protocol.pyis probably good to go, but the extra GET parameters like precision and retention probably need some love.See my posts in #191 for some additional notes.