This repository was archived by the owner on Oct 29, 2024. It is now read-only.
Fix unicode data handling in tag's content #296
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm discovered problems, while try to write data, with tags in unicode.
Fix test_make_lines_unicode() test. _get_unicode() with flag fails under py27 if tag contains unicode.
|
Great! Thank you for your work. |
aviau
added a commit
that referenced
this pull request
Feb 19, 2016
Fix unicode data handling in tag's content (Thanks @anonymouzz !)
|
Do you mind releasing a new version w/ this on PyPI? It's pretty critical for anyone handling unicode data in Python 2.7. |
|
+1 for a new viesion |
|
+1 also. As a workaround, i forked master for my own need but would prefer to keep using main package. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm discovered that client crashes in make_lines function if unicode data in tag content (under py27).
This patch fix it for me.