Skip to content
This repository was archived by the owner on Oct 29, 2024. It is now read-only.

Reimplement get_list_series #357

Closed
wants to merge 5 commits into from
Closed

Reimplement get_list_series #357

wants to merge 5 commits into from

Conversation

gaker
Copy link
Contributor

@gaker gaker commented Jul 30, 2016

Fixes #353

@gaker
Copy link
Contributor Author

gaker commented Jul 30, 2016

@aviau Let me know if you want anything additional on this.

@aviau
Copy link
Collaborator

aviau commented Jul 31, 2016

@gaker By merging another PR, I have broken the possibility of merging this one.

Can you please rebase or just pull master into your branch?

@gaker
Copy link
Contributor Author

gaker commented Jul 31, 2016

@aviau Done.

aviau
aviau reviewed Jul 31, 2016
View reviewed changes
influxdb/tests/client_test.py
@@ -484,6 +484,98 @@ def test_get_list_database_fails(self):
with _mocked_session(cli, 'get', 401):
cli.get_list_database()

<<<<<<< HEAD
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops! ヾ(⌐■_■)ノ♪

@gaker gaker force-pushed the get-list-series branch from 2bf035e to 8022eb7 Compare July 31, 2016 20:32
@gaker
Copy link
Contributor Author

gaker commented Jul 31, 2016

@aviau that's cleaned up now. Sorry about that.

@aviau
Copy link
Collaborator

aviau commented Aug 3, 2016

I don't really understand the response format.

[{'key': 'cpu_load_short,host=server01,region=us-west'}]

What is "key" here?

Shouldn't series just be a list like this?

[ "cpu_load_short,host=server01,region=us-west"]

@gaker
Copy link
Contributor Author

gaker commented Aug 3, 2016

@aviau Seems reasonable to me. I'll change it.

sebito91 added a commit that referenced this pull request Apr 7, 2020
@sebito91
feat(client): re-add support for 'show series' from legacy PR #357. C…
c694027 
…loses #353
@sebito91 sebito91 mentioned this pull request Apr 7, 2020
Merged
@sebito91
Copy link
Contributor

sebito91 commented Apr 7, 2020

Replaced by #806

@sebito91 sebito91 closed this Apr 7, 2020
sebito91 added a commit that referenced this pull request Apr 7, 2020
@sebito91
feat(client): re-add support for 'show series' from legacy PR #357. C…
ea1b995 
…loses #353 (#806)

* feat(client): re-add support for 'show series' from legacy PR #357. Closes #353

* chore(client): fix failing tests

* chore(client): update linters to pass
ocworld pushed a commit to AhnLab-OSS/influxdb-python that referenced this pull request Apr 13, 2020
@sebito91 @ocworld
feat(client): re-add support for 'show series' from legacy PR influxd…
d54a110 
…ata#357. Closes influxdata#353 (influxdata#806)

* feat(client): re-add support for 'show series' from legacy PR influxdata#357. Closes influxdata#353

* chore(client): fix failing tests

* chore(client): update linters to pass
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
pending contributor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bring back get_list_series
4 participants
@gaker @aviau @sebito91 @xginn8
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy