Skip to content
This repository was archived by the owner on Oct 29, 2024. It is now read-only.

Changed default requests timeout from 0 to None #41

Merged
merged 1 commit into from
Jun 9, 2014
Merged

Changed default requests timeout from 0 to None #41

merged 1 commit into from
Jun 9, 2014

Conversation

aviau
Copy link
Collaborator

@aviau aviau commented Jun 9, 2014

No description provided.

@aviau aviau changed the title Changed default timeout from 0 to None Changed default requests timeout from 0 to None Jun 9, 2014
jvshahid added a commit that referenced this pull request Jun 9, 2014
Changed default timeout from 0 to None
@jvshahid jvshahid merged commit d1f1cab into influxdata:master Jun 9, 2014
@aviau aviau mentioned this pull request Jun 9, 2014
@Dieterbe
Copy link

Dieterbe commented Jun 9, 2014

for anyone wondering if this fixes an issue they are seeing,
it just so happened i was debugging an issue today that turned out to be caused by this.

the symptom was that the influx client was opening the connection (syn), the server would reply (syn, ack) and than the client sends tcp reset. I was seeing this in my graphite-influxdb adapter.
upon a simple query like "list series",
requests/adapters.py's send() would catch a MaxRetryError and yields the ConnectionError

HTTPConnectionPool(host='graphite', port=8086): Max retries exceeded with url: 
                     /db/graphite/series?q=list+series&p=graphite&chunked=false&time_precision=s&u=graphite (Caused by <class 'socket.error'>: [Errno 115] Operation now in progress)",)

I thought maybe it was due to thread unsafety of my code, but turns out that InfluxDBClient::request() was throwing the exception, and this timeout fixes it

@MarkusTeufelberger
Copy link

Please push a new version to pypi soon, this bug was causing me quite some issues (I've now simply patched it manually in my local version).

@jvshahid
Copy link
Contributor

Done. 0.1.11 is pushed

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy