This repository was archived by the owner on Oct 29, 2024. It is now read-only.
fix for lost precision on float field values #430
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xginn8
suggested changes
Mar 25, 2017
| @@ -119,3 +119,19 @@ def test_quote_literal(self): | |||
| line_protocol.quote_literal(r"""\foo ' bar " Örf"""), | |||
| r"""'\\foo \' bar " Örf'""" | |||
| ) | |||
|
|
|||
| def test_float_with_long_decimal_fraction(self): | |||
There was a problem hiding this comment.
To conform to pep257 this public method should have a docstring, see #415
xginn8
approved these changes
Apr 8, 2017
|
thanks to you both! |
|
Any chance this could cause Decimal values to fail?
I think the problem might be that float() will return a float on a Decimal, but repr will actually return |
|
I guess I do hae something like this here :: Is there a workaround? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use
repr()instead ofstr()when casting floats into strings so thatfloat(repr(my_float)) == my_floatcan be guaranteed, which is not the case when usingstr()