This repository was archived by the owner on Oct 29, 2024. It is now read-only.
Improve performance on dataframe to line conversion #486
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Here is a small script to the test the performance of the proposed solution. Results on machine: |
|
@sebito91 It's squashed! |
xginn8
approved these changes
Aug 11, 2017
|
thanks @maxdolle! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function influxdb._dataframe_client.DataFrameClient._convert_dataframe_to_lines() is quite slow due when it comes to tags formatting (about 1 second for 10000 lines)
The slowest part was r.dropna() (line 312). I propose the attached solution that combines several steps into a single one to avoid the call to dropna().