This repository was archived by the owner on Oct 29, 2024. It is now read-only.
add '' to categorical columns if not already in categories #505
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f123cf4 to
9585b1a
Compare
|
This fixes the issue that I had raised. |
|
@omki2005 would you mind adding a test to make sure this transformation is properly applied? |
|
Hi xginn8, I'm a bit new to github. What exactly did you do when you did "Merge branch 'master' into master" ? |
|
@omki2005 all that means is that i merged |
|
@omki2005 is this still required? If not I'd like to close this for now. |
|
Hey @sebito91 |
|
I'm facing the same issue this PR is trying to solve. Without this patch, I have to convert all categorical columns to normal, string columns, blowing up my memory usage. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for issue #504