Skip to content
This repository was archived by the owner on Oct 29, 2024. It is now read-only.

Remove UDP Precision Restrictions #557

Merged
merged 1 commit into from
Feb 13, 2018
Merged

Remove UDP Precision Restrictions #557

merged 1 commit into from
Feb 13, 2018

Conversation

mdhausman
Copy link
Contributor

  • address issue UDP Precision still locked at seconds #554
  • UDP writes can now convert timestamps to the desired precision
    • add time_precision argument to InfluxDBClient.send_packet, defaults to None
  • add tests for udp precision
    • remove old udp precision failure tests

@mdhausman
Copy link
Contributor Author

So... I tracked down the bug that's causing tests to break, but I'm perplexed because it doesn't look to be related to my change. It should be broken on master as well.

Unless I'm misunderstanding, it's breaking here when it tries to send the dataframe in json format. In json, the points get processed through _convert_dataframe_to_json which, unlike _convert_dataframe_to_line, lacks a numeric_precision arg. Fields are pulled directly from columns with no logic involving numeric precision (e.g. _stringify_dataframe) at all. I feel like I must be misunderstanding, because I don't see how this test could have succeeded in the first place as written.

@mdhausman
Copy link
Contributor Author

mdhausman commented Jan 15, 2018 •
edited
Loading

Okay, I can see the same test failing in #556 and #555. I have to assume something is just out of whack here unrelated to my change.

@mdhausman
Copy link
Contributor Author

Tagging @aviau for awareness

@xginn8
Copy link
Collaborator

xginn8 commented Feb 10, 2018

Thanks for your contribution! Would you mind fixing the flake8 lint failures? Looks good otherwise.

Remove UDP Precision Restrictions
ca5db44 
- address issue influxdata#554
- UDP writes can now convert timestamps to the desired precision
    - add time_precision argument to `InfluxDBClient.send_packet`, defaults to None
- add tests for udp precision
    - remove old udp precision failure tests
@mdhausman mdhausman force-pushed the remove_udp_restrictions branch from 0ab0f74 to ca5db44 Compare February 12, 2018 20:42
@mdhausman
Copy link
Contributor Author

mdhausman commented Feb 12, 2018 •
edited
Loading

Did the thing @xginn8

@xginn8 xginn8 merged commit ed276e2 into influxdata:master Feb 13, 2018
@xginn8 xginn8 mentioned this pull request Jul 1, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@xginn8 xginn8 xginn8 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mdhausman @xginn8
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy