Skip to content
This repository was archived by the owner on Oct 29, 2024. It is now read-only.

Exception on udp write precision != 's' (fixes #67) #68

Closed
wants to merge 3 commits into from
Closed

Exception on udp write precision != 's' (fixes #67) #68

wants to merge 3 commits into from

Conversation

aviau
Copy link
Collaborator

@aviau aviau commented Oct 24, 2014

No description provided.

@jvshahid jvshahid mentioned this pull request Oct 24, 2014
@aviau
Copy link
Collaborator Author

aviau commented Oct 24, 2014

Looks like python3 exceptions are different. I'll go debug that.

@aviau aviau changed the title Exception un on udp write precision != 's' (fixes #67) Exception on udp write precision != 's' (fixes #67) Oct 24, 2014
@aviau
Copy link
Collaborator Author

aviau commented Oct 24, 2014

Exception is raised in pypy... I'll try to figure that out (no pypy on my machine)

If anyone can help. Go ahead.

The issue is that if self.use_udp and time_precision is not 's' evaluates true during the test_write_points_udp test

@aviau
Copy link
Collaborator Author

aviau commented Oct 24, 2014

I took a wild guess and assumed the "is" operator was different in pypy and I was right!

@jvshahid, the build passed.

@jvshahid
Copy link
Contributor

awesome, merging

@jvshahid jvshahid closed this in a8a17ad Oct 24, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy