[UR][CTS] Use ASSERT instead of EXPECT in test bodies
#19494
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`EXPECT` doesn't return from the current function, so a number of tests would keep going if they failed, in one case segfaulting due to writing to memory that was not allocated correctly. Standardise the test suite so that it always returns on the first failure using `ASSERT` where possible.
kbenzie
approved these changes
Jul 17, 2025
reble
approved these changes
Jul 17, 2025
|
@intel/llvm-gatekeepers Please merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EXPECTdoesn't return from the current function, so a number of testswould keep going if they failed, in one case segfaulting due to writing
to memory that was not allocated correctly.
Standardise the test suite so that it always returns on the first
failure using
ASSERTwhere possible.