added key interception to prevent form submission on enter key #10617
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using more specific selectors to prevent event bubbling Added explicit return false to ensure event propagation stops Moved the Enter key handling before the repeat initialization
|
@cdrini really sorry for the wait but I just couldn't get this up. And the force push was accidental 😓 . |
|
@cdrini @mekarpeles hello! Is there anything else this PR requires? |
cdrini
approved these changes
Jun 10, 2025
There was a problem hiding this comment.
Awesome, thank you @techy4shri ! Apologies for the long delay on this one. I tested on testing, and with the added changes, works like a charm!
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #10617 +/- ##
==========================================
- Coverage 17.27% 17.10% -0.18%
==========================================
Files 87 91 +4
Lines 4845 5000 +155
Branches 860 870 +10
==========================================
+ Hits 837 855 +18
- Misses 3477 3603 +126
- Partials 531 542 +11 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #10401
Technical
Modified
initClassificationValidation()inedit.js:preventDefault()to stop form submission on Enterrepeat('add')call to trigger classification additionfalseto prevent event bubblingTesting
Input is added as new classification
Page does not save/reload
Behavior matches ID Numbers field
Screenshot
Stakeholders
@cdrini