Skip to content

Fix performance of streaming long text #14941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fix performance of streaming long text #14941

wants to merge 3 commits into from

Conversation

krassowski
Copy link
Member

@krassowski krassowski commented Jul 19, 2025 •
edited
Loading

Fixes #14937

  • adds failing test
  • fixes the issue by using list of lines to accumulate stream instead or re-allocating a long string each time

CC @Darshan808

@krassowski krassowski mentioned this pull request Jul 19, 2025
Merged
@krassowski krassowski mentioned this pull request Jul 19, 2025
Merged
krassowski added a commit that referenced this pull request Jul 19, 2025
@krassowski
Fix mypy linting issue in dedupreloaded (#14942)
4d0c438 
As noticed in #14939 and #14941
@krassowski krassowski marked this pull request as ready for review July 19, 2025 09:33
@krassowski krassowski added this to the 9.5 milestone Jul 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
9.5
Development

Successfully merging this pull request may close these issues.

Printing many lines of output is ~50x slower in ipython v9.1.0 and above compared to v9.0.2 and below
1 participant
@krassowski
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy