PAR Ghaith & Marie #151
Closed
PAR Ghaith & Marie #151
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| var hacker2 = "Ghaith"; | ||
| console.log("The navigator's name is " + hacker2); |
There was a problem hiding this comment.
You can "generate" a dynamic name by asking the user :
var hacker2 = prompt("What's your name ? ")| var navigatorSize = hacker2.length; | ||
|
|
||
| if (driverSize > navigatorSize){ | ||
| console.log("the navigator's name has the longest name, it has " + driverSize + " characters."); |
There was a problem hiding this comment.
small typo error here :
the driver's has the longest name, otherwise it will be the navigator everytime ;)
|
Good job! except for some small mistake I mention you did a great job, as it's just the beginning you could have wrote less "complex" stuff for the last iteration per example but otherwise 🥇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@GhaithHan