BCN - Selim Lebbady #260
Closed
BCN - Selim Lebbady #260
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tawebbcn
reviewed
Oct 23, 2018
|
|
||
| var driver = "John"; | ||
| console.log("The driver's name is ",driver); | ||
| let navigator = prompt("What's the navigator's name?"); |
There was a problem hiding this comment.
Try to make your code consistent and use always the same structure, in this case you used always var and here let.
tawebbcn
reviewed
Oct 23, 2018
| } | ||
| else { | ||
| console.log("Yo, the navigator goes first definitely"); | ||
| } |
There was a problem hiding this comment.
Amazing but there's an easier way. JS already knows the order so you can simplify your code only comparing the first two letters of the names and it will knows which goes first. Like that :
`
var hacker1Order = hacker1[0];
var hacker2Order = hacker2[0];
if (hacker1Order < hacker2Order) {
console.log('The driver's name goes first');
} etc....
`
tawebbcn
reviewed
Oct 23, 2018
| "y":25, | ||
| "z":26 | ||
| }; | ||
| debugger; |
There was a problem hiding this comment.
Try to clean your code once you've finished. But cool, you used the debugger!!
tawebbcn
reviewed
Oct 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.