MIA FTWD Anghy Pomar js #386
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice job! I'm very impressed that you covered the edge cases for the palindromes by checking for spaces and capitalization. The only small thing I see that can be fixed is that your word count is a little bit off. Right now, it's counting 347 instead of 349. The reason for that is that while it's checking for words separated by spaces, it isn't checking for words separated by line breaking. Since there are 2 line breaks separating the paragraphs, 2 words are going uncounted. I wouldn't fixate on it too hard, but consider approaching this if you have extra time. Other than that, everything is flawless. Keep up the good work!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.