[ING-FT-112019]-Kai and Tomasz #579
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| console.log(`The driver has the longest name, it has ${hacker1.length} characters`); | ||
| else if (hacker1.length < hacker2.length) | ||
| console.log(`It seems that the navigator has the longest name, it has ${hacker2.length} characters`); | ||
| else |
There was a problem hiding this comment.
prefer an explicit condition like " === "
| let str = ""; | ||
|
|
||
| for (let i = 0; i < hacker1.length; i++) { | ||
| str = str + hacker1.charAt(i) + " "; |
| let str2 = ""; | ||
|
|
||
| for (let i = hacker2.length - 1; i >= 0; i--) { | ||
| str2 = str2 + hacker2.charAt(i); |
| console.log(`The driver's name goes first`); | ||
| else if (hacker1 > hacker2) | ||
| console.log(`Yo, the navigator goes first definitely.`); | ||
| else |
There was a problem hiding this comment.
prefer explicit condition like " = "
|
|
||
| for (let i = 0; i <= text.length; i++) { |
There was a problem hiding this comment.
ERROR: correct to i < text.length
| let found = 0; |
There was a problem hiding this comment.
Could be greatly simplified. Please read documentation about indexOf()
|
|
||
| let str = ""; | ||
|
|
||
| for (let i = 0; i < hacker1.length; i++) { |
There was a problem hiding this comment.
prefer use of localeCompare() as per lesson instructions
|
This pull request has been automatically marked as stale because it didn't have any recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
This pull request is closed. Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.