Skip to content

MIA-Jens Heilemann- JS Basic Algorithms #99

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

jkai7
Copy link

@jkai7 jkai7 commented Apr 2, 2018

No description provided.

@ianizaguirre
Copy link

Hi here is some feedback....

  1. For "Loops" you were asked to make 3 conditions but you only made one 🙁 ...
  • You wrote:
if (hacker1.length > hacker2.length) {
  console.log("Driver has longer name, it has 7 characters");
}
  • It should have been:
if (hacker1.length > hacker2.length) {
  console.log('The Driver has the longest name, it has ' + hacker1.length + ' characters');
} else if (hacker1.length < hacker2.length) {
  console.log('Yo, navigator got the longest name, it has ' + hacker2.length + ' characters');
} else {
  console.log('wow, you both got equally long names, ' + hacker1.length + ' characters');
}
  1. You forgot to do the last part which asks about printing certain strings depending on the lexicographic order (AKA alphabetical order).

Aside from that, good job and keep up the good work! 😁

Kind Regards,
Ian Izaguirre | Ironhack TA

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy