install latest stable phpunit with simple-phpunit #115
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We can't instal phpunit 8.2 on the php 7.1 image, not sure we can do this conditionally 😢 Maybe we should wait for SF (remember.. November 😅 ) |
|
Alternatively, affter symfony/symfony#32059 we could perhaps bump SF PHPUnit Bridge to 4.4@dev for a while 🤔 That's most easy. |
|
Closing for now, the duplicate |
Duplicate is not possible, but it could be an array if I remember it right :) |
|
can you share an example :D Could be worth it cosmetically for #116 (instead of If it's possible, ideally we'd be able to tag individual That would allow installing simple-phpunit itself still on php 7.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes phpunit-7.x + phpunit-8.x avaialble out-of-the-box for the time being. That is till November 2019 when SF 4.4 is released: symfony/symfony#32059
I think it's worth to pre-install it here for convenience and general availability while needed.
I'll try to work on a fix before SF 4.4 to allow picking the latest stable (e.g. using
SYMFONY_PHPUNIT_VERSION=@stablehere or as a SF core default), so we dont have to rely on hard coded upper version constraint.