Keyboard: keydown and keyup #265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

pasor1 merged 6 commits into javascript-tutorial:master from pierangelomiceli:019_keyb

Mar 24, 2021

Contributor

pierangelomiceli commented Mar 15, 2021

No description provided.

pierangelomiceli added 4 commits

March 14, 2021 14:18


          prima parte tradotta

c364920


          continuazione traduzione

19ff585


          fine traduzione articolo


          traduzione materiale, e correzioni testi articolo

306b86e

javascript-translate-bot added the review needed label

javascript-translate-bot requested a review from a team

March 15, 2021 14:55

javascript-translate-bot mentioned this pull request

Italian Translation Progress #1

Open

Dorin-David reviewed

View reviewed changes

2-ui/3-event-details/7-keyboard-events/2-check-sync-keydown/solution.view/index.html Outdated Show resolved Hide resolved

Dorin-David reviewed

View reviewed changes

2-ui/3-event-details/7-keyboard-events/article.md Outdated Show resolved Hide resolved

Dorin-David reviewed

View reviewed changes

2-ui/3-event-details/7-keyboard-events/article.md Outdated Show resolved Hide resolved

Dorin-David reviewed

View reviewed changes

2-ui/3-event-details/7-keyboard-events/article.md Outdated Show resolved Hide resolved

Dorin-David reviewed

View reviewed changes

2-ui/3-event-details/7-keyboard-events/article.md Outdated Show resolved Hide resolved

Dorin-David reviewed

View reviewed changes

2-ui/3-event-details/7-keyboard-events/article.md Outdated Show resolved Hide resolved

Dorin-David reviewed

View reviewed changes

2-ui/3-event-details/7-keyboard-events/article.md Outdated Show resolved Hide resolved

Dorin-David reviewed

View reviewed changes

2-ui/3-event-details/7-keyboard-events/article.md Outdated Show resolved Hide resolved

Dorin-David reviewed

View reviewed changes

2-ui/3-event-details/7-keyboard-events/article.md Outdated Show resolved Hide resolved

Dorin-David reviewed

View reviewed changes

2-ui/3-event-details/7-keyboard-events/article.md Outdated Show resolved Hide resolved

Dorin-David reviewed

View reviewed changes

2-ui/3-event-details/7-keyboard-events/article.md Outdated Show resolved Hide resolved

Dorin-David reviewed

View reviewed changes

2-ui/3-event-details/7-keyboard-events/article.md Outdated Show resolved Hide resolved

Dorin-David reviewed

View reviewed changes

2-ui/3-event-details/7-keyboard-events/article.md Outdated Show resolved Hide resolved

Dorin-David reviewed

View reviewed changes

2-ui/3-event-details/7-keyboard-events/article.md Outdated Show resolved Hide resolved

Dorin-David reviewed

View reviewed changes

Contributor

Dorin-David left a comment

Ottima traduzione Pier! Mi sono permesso di suggerire alcune piccole modifiche, fanne quello che vuoi.

longo-andrea added changes requested needs +1 and removed review needed labels


          Apply suggestions from code review

a31e083

Co-authored-by: Dorin David <70648503+Dorin-David@users.noreply.github.com>

Contributor Author

pierangelomiceli commented Mar 20, 2021

/done

javascript-translate-bot added review needed and removed changes requested labels

longo-andrea removed the review needed label

pasor1 requested changes

View reviewed changes

2-ui/3-event-details/7-keyboard-events/2-check-sync-keydown/solution.md Outdated Show resolved Hide resolved

2-ui/3-event-details/7-keyboard-events/2-check-sync-keydown/task.md Outdated Show resolved Hide resolved

2-ui/3-event-details/7-keyboard-events/article.md Outdated Show resolved Hide resolved

2-ui/3-event-details/7-keyboard-events/article.md Outdated Show resolved Hide resolved

2-ui/3-event-details/7-keyboard-events/article.md Outdated Show resolved Hide resolved

2-ui/3-event-details/7-keyboard-events/article.md Outdated Show resolved Hide resolved

javascript-translate-bot added the changes requested label

javascript-translate-bot commented Mar 21, 2021

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

pasor1 added 2nd review done and removed needs +1 labels

Contributor

longo-andrea commented Mar 23, 2021

visto che è aperta da oltre una settimana, prendo io in carico le modifiche suggerite cosi poi è pronta per il merge


          Apply suggestions from code review

9f1aad1

Co-authored-by: Simone Pasini <66781510+pasor1@users.noreply.github.com>

Contributor

longo-andrea commented Mar 23, 2021

/done

longo-andrea added ready to merge and removed changes requested labels

pasor1 approved these changes

View reviewed changes

javascript-translate-bot added the needs +1 label

pasor1 removed 2nd review done needs +1 labels

Contributor Author

pierangelomiceli commented Mar 23, 2021

potete fare merge quando volete.

pasor1 merged commit 60f5c83 into javascript-tutorial:master

javascript-translate-bot commented Mar 24, 2021

Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.

Alternative Proxies:

Alternative Proxy