Provide access_token in header instead of URI #49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wilsonge
reviewed
Sep 14, 2020
wilsonge
reviewed
Sep 14, 2020
Fixed typo
|
Yes. The "failing check" is caused by a composer problem in Travis, not by this PR. |
|
@nibra can you update your branch to get drone foe tests plz |
|
@HLeithner Done |
|
@nibra can you please do a 1.7.1 release with the changes done here? |
|
Done. |
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #48
Summary of Changes
Adds the
authHeader()method to \Joomla\Github\AbstractGithubObject.Changes unit tests to ensure the required treatment of header information.
Testing Instructions
Verify that the changes in the unit tests will test the right things.
Run PHPUnit.
Documentation Changes Required
API documentation will be updated automatically.