Misc.less issue fix #244
Open
Misc.less issue fix #244
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Importantly, the bootstrap.less file is now added as "reference" only. So that bootstrap css will not get included in the LESS output css.
1. colors do not match at times. This is due to usage of variables for colors instead of hardcoding every single color. 2. CSS corrections like using px at times. 3. Moving styles around.. this happens due to LESS compilation. Overall the net impact will not be visible on the page.
|
I think my next pushes also got auto added here. All the LESS changes are also done. So this includes not only fix for 244 issue.. but for other fixes as mentioned above too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for the issue #242.
I am not able to recall the reason why those styles were left there in misc.less. But most likely they are leftovers from over JQuery UI-bootstrap2 misc.less files.
On a side-note, I also am seeing that since my last commit about 6 months ago .. there has been few changes to the css version of the file and hence LESSd version and CSS version do not match anymore. While the differences are small.. there are quite a few occurrences of such differences. I will review the less version in coming days to make it matching with the CSS version.