Additional: max size and number of files #2087
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Arkni
requested changes
Oct 8, 2017
src/additional/maxfiles.js
Outdated
|
|
||
| if ( $( element ).attr( "type" ) === "file" ) { | ||
| if ( element.files && element.files.length ) { | ||
| if ( element.files.length > param ) { |
There was a problem hiding this comment.
Can you please merge the above two if blocks?
There was a problem hiding this comment.
Which two? There are three of them. Lines 8 and 9, I presume?
Arkni
reviewed
Oct 8, 2017
src/additional/maxfiles.js
Outdated
| @@ -0,0 +1,16 @@ | |||
| //Limit the number of files in a FileList. | |||
There was a problem hiding this comment.
Just for consistency with the other comments in this project, can you add a space before the comment?
The same goes for other comments bellow.
|
@Arkni Done. |
Arkni
approved these changes
Oct 8, 2017
|
Thanks a lot for your contribution :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a continuation of abandoned PR #1512, in that it validates the maximum size of a selected file.
Since the "file" type can contain the multiple attribute, another method was added to validate the maximum size of all selected files. Finally, a third method was added to validate the maximum number of files.