Skip to content

Replaced deprecated jQuery functions #2335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 24, 2020
Merged

Replaced deprecated jQuery functions #2335

merged 1 commit into from
Jun 24, 2020

Conversation

bytestream
Copy link
Member

Description

Replaces functions deprecated in jQuery 3 as per https://api.jquery.com/category/deprecated/

@bytestream bytestream force-pushed the jquery-deprecations branch from ba82525 to 38882c7 Compare June 23, 2020 11:41
@bytestream bytestream changed the title jQuery deprecations Replaced deprecated jQuery functions Jun 23, 2020
@bytestream bytestream mentioned this pull request Jun 23, 2020
Merged
@bytestream bytestream force-pushed the jquery-deprecations branch from 38882c7 to 272bb4f Compare June 23, 2020 13:23
staabm
staabm approved these changes Jun 23, 2020
View reviewed changes
Copy link
Member

@staabm staabm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm - thank you

@staabm staabm requested a review from Arkni June 23, 2020 20:02
Arkni
Arkni reviewed Jun 24, 2020
View reviewed changes
Copy link
Member

@Arkni Arkni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, it looks good to me. I left a comment about the isArray method that I would like to discuss

@bytestream
Core: Replaced deprecated jQuery functions
360de29 
Replaced $.isArray and $.isFunction
@bytestream bytestream force-pushed the jquery-deprecations branch from 272bb4f to 360de29 Compare June 24, 2020 11:12
Arkni
Arkni approved these changes Jun 24, 2020
View reviewed changes
Copy link
Member

@Arkni Arkni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks a lot for your contribution :)

@Arkni Arkni merged commit 79bed39 into jquery-validation:master Jun 24, 2020
This was referenced Mar 11, 2021
Merged
Merged
Closed
Open
@bytestream bytestream deleted the jquery-deprecations branch May 23, 2022 22:38
@bytestream bytestream restored the jquery-deprecations branch May 23, 2022 22:38
@bytestream bytestream deleted the jquery-deprecations branch May 23, 2022 22:38
@bytestream bytestream restored the jquery-deprecations branch May 23, 2022 22:38
@MrRaja23 MrRaja23 mentioned this pull request May 24, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@staabm staabm staabm approved these changes

@Arkni Arkni Arkni approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bytestream @staabm @Arkni
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy