Changed lastElement to lastActive in keyup. Fixes #244 #396
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixes #244 |
|
Okay, I just found an issue with this. It will trigger validation as soon as you tab to it, even if you've never entered anything before. |
This was referenced Apr 24, 2012
Closed
|
Landed in c41f2f6 - squashed the second commit, updated the commit message. |
This was referenced May 25, 2012
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems the keyup method was using a different variable to keep track of the last active element. I switched it to the
lastActiveelement which is set in onfocus, which makes more sense and fixes the issue.