Deprecate existing extensions #1026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- the safe: false declaration isn’t needed now that we have jekyll-redirect-from on the whitelist. - Jekyll auto regeneration was causing the gem versions to be printed constantly, so we now disable that printing in the Gemfile.
|
LGTM 👍 |
|
@ethanresnick - I'm glad you updated the docs since I was about to start implementing the now-deprecate extensions. I'm curious what the plan moving forward is. Is there some place I could follow along with the discussion? |
|
Yes, in #957 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This follows a conversation with @dgeb today. The thinking is that keeping the old extensions, and the old negotiation rules, online does more harm than good, as we don’t want people to use them anymore nor do we want to support them going forward.