updates schema to allow URI references #1169
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As discussed in json-api#898 JSON API specification does not make any assertions about URI structure. Also specification contains examples using "relative URIs". RFC 3986, which is referenced by JSON Schema specification, distinguish between an uri and an uri reference like "relative" or "partial URIs": > 1.2.3. Hierarchical Identifiers > [...] > NOTE: Previous specifications used the terms "partial URI" and "relative > URI" to denote a relative reference to a URI. As some readers misunderstood > those terms to mean that relative URIs are a subset of URIs rather than > a method of referencing URIs, this specification simply refers to them as > relative references. Therefore relative URIs would fail validation if `uri` format (8.3.6 in JSON Schema draft) is used. `uri-reference` format (8.3.7) allow both.
|
FWIW, linking to comment that the JSON SCHEMA is not authoritative #440 (comment) |
Closed
|
@dgeb perhaps we should add a comment somewhere to that effect? |
elliotttf
added a commit
to elliotttf/jsonapi-validator
that referenced
this pull request
Aug 8, 2017
elliotttf
added a commit
to elliotttf/jsonapi-validator
that referenced
this pull request
Aug 8, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #898 JSON API specification does not make any assertions
about URI structure. Also specification contains examples using "relative
URIs".
RFC 3986, which is referenced by JSON Schema specification, distinguish
between an uri and an uri reference like "relative" or "partial URIs":
Therefore relative URIs would fail validation if
uriformat (8.3.6 in JSONSchema draft) is used.
uri-referenceformat (8.3.7) allow both.