Clarify pagination links in relationship object #1251
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 I'm gonna merge this. I think this addresses #509, though there were also some requests in that issue for us to add more examples, so I'll let you decide whether to close that issue now or add the examples first. |
joananeves
added a commit
to joananeves/json-api
that referenced
this pull request
Apr 18, 2018
* json-api-gh-pages: (259 commits) jsonapi-realizer is a new server side hander, intended to be a sister to jsonapi-serializers (json-api#1267) Added DenaliJS to the Node framework list (json-api#1264) Added Vox to iOS implementations (json-api#1262) Update scala-jsonapi link (json-api#1263) added sarala javascript packages to implementations (json-api#1260) Add SimpleJSONAPIClient to Ruby implementations (json-api#1257) Removed py-jsonapi (json-api#1258) Move fast_jsonapi to it\'s proper place in the ruby server list (json-api#1256) Clarify pagination links in relationship object (json-api#1251) move safrs to server libraries (json-api#1253) Add fast_jsonapi to Ruby Lists (json-api#1252) JSON API Playground link added to implementations (json-api#1248) Add SAFRS to list (json-api#1250) Always return "included" where "include" has been requested (json-api#1236) ngx-jsonapi added to implementations (json-api#1228) PHP library for JSON API + Doctrine add @crnk/angular-ngrx implementation Add jsonapi-mock to implementations Add raml-json-api to implementations Clarify pending async process response json-api#1223 ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a clarification, not a change, so I'm comfortable using MUST here.
I believe this is just a refinement of the pagination section which already contains statements such as:
In other words, the pagination links clearly correspond to the collection. And for relationship objects, the collection is relationship data, not related resources.
Closes #509