cleanup(profiles): special case default handling of unrecognized query param vals #1306
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@wimleers Wanted to make sure you saw this |
dgeb
reviewed
Nov 3, 2018
dgeb
reviewed
Nov 3, 2018
dgeb
requested changes
Nov 3, 2018
There was a problem hiding this comment.
@ethanresnick Just needs some minor tweaks to improve clarity - looks good overall.
Per @dgeb’s suggestions
|
@dgeb Ok, I've applied your suggestions. Take a look! |
dgeb
approved these changes
Nov 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, if a profile was applied with a query parameter that had an unrecognized value, the profile was ignored by default. This makes the default to fail with a 400 Bad Request instead. I think this better reflects the semantics that, when using query parameters, the client is trying to force the server to apply the profile, or fail the request.