feat(profiles): tweak review language #1353
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This just fixes a small mistake (we said “If your profile meets these three criteria…”, but we have 4 criteria now) and it replaces: “complies with JSON:API's requirements for profiles” with “complies with the JSON:API spec and its requirements for profiles” which just lets us note during review any violations of other areas of the JSON:API spec.
|
There's absolutely nothing controversial here, so I'm gonna go ahead and merge it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This just fixes a small mistake (we said “If your profile meets these
three criteria…”, but we have 4 criteria now) and it replaces:
“complies with JSON:API's requirements for profiles” with
“complies with the JSON:API spec and its requirements for profiles”
which just lets us note during review any violations of other areas of
the JSON:API spec.