Typo in cursor pagination profile #1374
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice find! LGTM :) |
|
Oh, hah, you work for https://decorrespondent.nl/ — awesome :) I've been a subscriber for years. I see you're building https://github.com/lode/jsonapi, your own PHP-based JSON:API implementation. Why build and maintain your own? It looks like you started working on it a long time ago, so probably that's why: few implementations existed back then. |
|
Thanks! |
|
You're welcome! I build it because I love the idea of JSON:API and because I had a feeling an implementation could be simple to use without knowing the spec, which most others didn't do back then. Further it is just fun to make stuff right? :) Btw, great you're a member of DC! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.