Skip to content

Remove profile aliasing from 1.1-rc2 #1412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 12, 2019
Merged

Remove profile aliasing from 1.1-rc2 #1412

merged 1 commit into from
Aug 12, 2019

Conversation

gabesullice
Copy link
Contributor

@gabesullice gabesullice commented Aug 9, 2019

This PR is derived from #1410 which included this same alias removal. Per @dgeb' s request, I've broken this out into its own PR. I agree that this will make this change easier to review and consider.

This PR supersedes #1362.

Motivation

Aliasing anticipates a problem that I'm not yet convinced we'll encounter. That is, it attempts to make it possible for a server to support profiles with conflicting keywords.

Unfortunately, aliasing is not a trivial thing to implement on the client or the server. A global dictionary must be computed for every HTTP message by either the client or the server. There is no guarantee that two implementations will use the same aliases, nor that they will even use the same aliases between requests. In systems that have hierarchical (de)serialization components, that global dictionary must be shared between them and that can be a cumbersome process. Even after deserialization, every processor must also know about the aliases too, since processors will be looking for specific keywords.

I propose we remove aliasing from v1.1 of the spec. If they really does become necessary, it shouldn't be too difficult to add them to a subsequent version of the spec.

@dgeb
Copy link
Member

dgeb commented Aug 12, 2019

@gabesullice thanks for breaking out this change as a separate PR. LGTM.

@wimleers
Copy link
Contributor

IIRC I also found aliasing one of the more confusing things to wrap my head around.

I wanted to read it again on the website to try to remember what exactly I found confusing, but now there's only https://jsonapi.org/format/1.1/, the 1.1-RC1 release is gone. Is this intentional or accidental?

@dgeb
Copy link
Member

dgeb commented Aug 14, 2019

@wimleers Sorry for the confusion. We have reverted 1.1 to be a working draft as per this discussion: #1403 (comment)

I'm working with @gabesullice to stabilize a modified vision for 1.1 ASAP.

@wimleers
Copy link
Contributor

wimleers commented Aug 14, 2019

I know! But I think that for posterity sake and for full transparency, it'd be good to keep old RCs around. "Cool URIs don't change" :) But I just noticed that the old URL was indeed also …/1.1, not …/1.1-rc1. So the choice of the URL just wasn't ideal, because that is indeed a good reason to not keep 1.1-RC1 published.

Ignore my request :)

@dgeb
Copy link
Member

dgeb commented Aug 14, 2019

Well I totally agree about URIs not changing. And I'm open to publishing each RC to its own URL and leaving it available in perpetuity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy